-
Notifications
You must be signed in to change notification settings - Fork 246
first part of changes for OpenShift compatibility #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for lowcoder-cloud pending review.Visit the deploys page to approve it
|
Thank you! I will have a look in next couple days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is your PR by this "work in progress" or isolated and you think we can merge it as is, so users profit from it already?
This one is working for itself and can be merged as is. It helps for different kind of non-root usage. The other changes to the Dockerfile for full OpenShift compatibility will be another PR. |
👷 Deploy request for lowcoder-test pending review.Visit the deploys page to approve it
|
# Conflicts: # deploy/docker/api-service/entrypoint.sh
Hello - as it was not merged i added other fixes with supervisord config and dockerfile file access rights.
as said - this image will work with RedHat OpenShift too. |
Thank you very much for work on this! |
Proposed changes
Current Lowcoder images cannot run in Openshift Container Platform because they expect to be running as root which is not true for OpenShift. Openshift automatically starts all container at a RANDOM non-privileged user id
These changes are not complete - for full Openshift compatibility a lot more needs to be changed - will be discussed in #616. These changes are the "easy" ones that will not need updates or changes inside your current setup (should be non-breaking)
Additionally some linting of existing code was done to be more posix compliant.
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
x
in the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
x
in the boxes that apply.Further comments
As this is only the first part needed discussion can be done further at #616